Skip to content

fix(material-experimental/mdc-progress-bar): improve buffer color #22152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2021
Merged

fix(material-experimental/mdc-progress-bar): improve buffer color #22152

merged 2 commits into from
Mar 10, 2021

Conversation

andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Mar 9, 2021 •
edited
Loading

Addresses #22130 on the MDC-side of things. Need to consider solutions for legacy progress bar

BEFORE:

Screen Shot 2021-03-08 at 8 44 38 PM

Screen Shot 2021-03-08 at 8 44 31 PM

AFTER:

Screen Shot 2021-03-08 at 8 43 40 PM

Screen Shot 2021-03-08 at 8 43 48 PM

@andrewseguin andrewseguin added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Mar 9, 2021
@andrewseguin andrewseguin requested a review from crisbeto March 9, 2021 03:49
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 9, 2021
@andrewseguin andrewseguin reopened this Mar 9, 2021
crisbeto
crisbeto approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM, but have you tried that the opacity doesn't reveal anything underneath the bar? E.g. we have the dotted animations for buffer mode which is just another element under the progress bar.

Progress_bar__Angular_Material_-_Google_Chrome_2021-03-09_16-52-37

@andrewseguin
Copy link
Contributor Author

Yeah, what's nice with MDC is that the dotted bar shrinks as the buffers gets bigger. In our legacy component, the dots extend the full width which is making the same solution tricker.

Going to see if our legacy component can also shrink the dotted bar as well so we can match the solution. Otherwise, I can't seem to get a lightness/blackness/saturation combination that looks good for all palettes. Opacity is definitely the way to go

@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Mar 10, 2021
@mmalerba mmalerba added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Mar 10, 2021
@mmalerba mmalerba merged commit 97f1ccc into angular:master Mar 10, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewseguin @crisbeto @mmalerba